Resolve Drop calls #1467
Open
Resolve Drop calls #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready but based on #1477 |
|
Charon failure is expected: this adds new variants to |
|
I've rebased this, it's ready |
W95Psp
approved these changes
Jun 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Could |
|
ah.. yes, that's very likely :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so we gather the data needed to know what code is called on a
dropterminator.By default, this is best-effort: we translate a trait ref if we find one. This also adds a
resolve_drop_boundsoption (maybe this should be renamed) which addsT: Dropbounds to every possible generic parameter and associated type, which guarantees that we can find the rightDropimpl.The one thing that's missing is the implicit Drop impls (so-called "drop glue") that exist for ADTs without an explicit
impl Drop; these are represented asDropData::Glue, and the corresponding MIR body is added toFullDefso it can be translated by charon.